MediaWiki talk:Common.js

Submitted script change 603 rejected
The recently submitted change to this JavaScript page (revision 603) was rejected by the FANDOM review process. Please make sure you meet the Custom JavaScript guidelines.

I'm a li'l wary of this: var reg = /(.*:.*):([0-9]*)/g var index = reg.exec(jarray[i])

Something in my gut tells me it could be exploited because reg can be literally anything, and exec will execute on whatever the value of reg. Maybe I'm being overly cautious, though, so please, if you want a second opinion, consult with Rappy on or after 15 Sept 2017. Thanks! CzechOut 22:48, September 12, 2017 (UTC)

Hm, maybe you can suggest some changes? Not sure how the .exec would produce a security concern. The numbers after the colons were an addition to the code to add numbers to the crafting grid.

ChocoParrot (talk) 01:39, September 13, 2017 (UTC)

Maybe it'd be better if I did something like this? var reg = /([A-z]*:[0-9]*):([0-9]*)/g var index = reg.exec ( jarray[ i] )

ChocoParrot (talk) 01:44, September 13, 2017 (UTC)